Fix for es6 import error #189
Conversation
|
@bunkat can we please get this merged and released? it's blocking our upgrade to webpack 2. Otherwise, we'll have to drop the library and find a different solution. |
|
@bunkat can we please get this merged and released? We are using webpack2 and ussing a forked version in the meantime :-) |
|
@Chexpir, due to the lack of response and this project being MIT licensed, we simply pulled it in-house. Not ideal, but better than continually waiting. |
| }); | ||
|
|
||
| require(process.env['LATER_COV'] ? "./later-cov" : "./later"); | ||
| if (process.env['LATER_COV']) { |
There was a problem hiding this comment.
you should also check if process is defined before trying to access env. webpack will throw an error here. I did the same fix in #208
|
Given that it's been six months since this PR was opened and the last post by the author of this project was in October of '16 requesting help since he no longer used it, I think it safe to assume this is abandoned. If anyone wants to fork it and correct the issues, that's probably the best course of action at this point. |
|
@icfantv If someone is willing to do maintenance work, it would probably be better for them to just reply to the lib author's call for help and make the fixes here, no? Unfortunately afaics no one has stepped up to do so yet |
|
@icfantv hi wondering if you are still maintaining an in-house version of this library? Care to make it public if so? |
|
@kirkins I wouldn't say maintaining. Rather, we pulled it in house and fixed the bug. I don't recall it being touched since. Looks like it was also moved so we lost the history. Here's the current version: https://github.com/spinnaker/deck/tree/master/app/scripts/modules/core/src/utils/later |
|
@icfantv thanks! |
|
@kirkins Sure. |
|
This issue is now fixed per my work with Bree, I have an updated fork of this package called |
|
Closing as #208 is better |
8 participants
Fix for the import error when using es6 import syntax.
#153